[SPARK-54438][PYTHON] Consolidate ArrowStreamAggArrowIterUDFSerializer into ArrowStreamAggArrowUDFSerializer #53328
+44
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
Yicong-Huang
force-pushed
the
SPARK-54438/refactor/consolidate-serde-for-sql-grouped-agg-arrow
branch
from
03a410d to
19d35ba
Compare
Yicong-Huang
force-pushed
the
SPARK-54438/refactor/consolidate-serde-for-sql-grouped-agg-arrow
branch
from
19d35ba to
7b9526f
Compare
Contributor
Author
|
@zhengruifeng could you please review this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR consolidates
ArrowStreamAggArrowIterUDFSerializerwithArrowStreamAggArrowUDFSerializer.Why are the changes needed?
When the iterator API was added for Arrow grouped aggregation UDFs, a new
ArrowStreamAggArrowIterUDFSerializerclass was created. However, this class is nearly identical toArrowStreamAggArrowUDFSerializer, differing only in whether batches are processed lazily (iterator mode) or all at once (regular mode). By consolidating these two classes, we reduce code duplication and maintain consistency with similar serializer consolidations.Does this PR introduce any user-facing change?
No, this is an internal refactoring that maintains backward compatibility. The API behavior remains the same from the user's perspective.
How was this patch tested?
Existing Tests
Was this patch authored or co-authored using generative AI tooling?
No